search

cefsharp / cef-binary

NuGet repackaging of the CEF binaries provided by Chromium Embedded Framework
https://cef-builds.spotifycdn.com/index.html
Other
110 stars 87 forks source link

Added NoDebug option to avoid debug builds, support zip and 7z archiv… #67

Closed mitchcapper closed 6 years ago

mitchcapper commented 6 years ago

…es with Extension option, and can auto detect build from local file, also better exception handling.

There is one line #565 in the new file, I changed the extract arg to pay attention to paths. Given the .tar.bz2 format however the tar isn't really in a sub-path so I believe should not cause an actual change.

The exception handling I can also remove, not functionally required but can be helpful for tracking down errors.

amaitland commented 6 years ago

Formatting is a little out, though it's not exactly brilliant across the whole file. I can fix that after merge, might even switch back to using tabs as it doesn't make a whole lot of sense to use spaces in this project.

As for NoDebug, it kinda sounds like we're disabling debugging for the script, so maybe a more descriptive name to make it clearer that the script is ignoring CEF Debug builds?

Once this is merged the wiki should probably be updated to include some usage examples, what do you think?

mitchcapper commented 6 years ago

NoDebugBuild? NoDebugPackage? Agree about the wiki. I am finalizing some performance timing expectations right now with my Dockerfiles which also have several use cases.

amaitland commented 6 years ago

Maybe NoCEFDebugBuild?

amaitland commented 6 years ago

Actually NoDebugBuild is probably just fine.

mitchcapper commented 6 years ago

Sorry I do try to match whitespace but as it was mixed my normal replace tabs with spaces causes more changes than it resolved. I manually updated the lines I only changed to spaces (but all for moving back to tabs:)).

amaitland commented 6 years ago

Totally understand, it's a mess. Will merge now and test out the changes using Appveyor for an updated CEF build.

amaitland commented 6 years ago

Formatting changed, hopefully it makes things easier going forward.

Had to add an additional check creating the Nuget folder, nothing serious, see https://github.com/cefsharp/cef-binary/commit/e3647eac344ae95f04f688d7cffa1bd748d10ab6

Packages build successfully, will upgrade master shortly and see how they go.

mitchcapper commented 6 years ago

documentation added.