search

cefsharp / cef-binary

NuGet repackaging of the CEF binaries provided by Chromium Embedded Framework
https://cef-builds.spotifycdn.com/index.html
Other
110 stars 87 forks source link

Reset environment variables after each build #91

Closed kpreisser closed 3 years ago

kpreisser commented 3 years ago

Reset the environment variables (PATH, LIB, LIBPATH, INCLUDE) set by vcvarsall.bat after each build. This should avoid generating a too long PATH environment variable which could cause an error like "The input line is too long" (as seen in the build after merging #90).

See https://github.com/cefsharp/cef-binary/pull/90#issuecomment-760724416

amaitland commented 3 years ago

Thanks 👍

amaitland commented 3 years ago

Build is queued.

https://ci.appveyor.com/project/cefsharp/cef-binary/builds/37290341

kpreisser commented 3 years ago

Looks like the build succeeded :+1:

I can see that version 88.1.2 of cef.sdk (which includes the arm64 libs) was uploaded to MyGet. The cef.redist and chromiumembeddedframework.runtime were also uploaded, but only for x64 and x86 (maybe the arm64 packages need to be created first).

Thanks!

amaitland commented 3 years ago

The cef.redist and chromiumembeddedframework.runtime were also uploaded, but only for x64 and x86 (maybe the arm64 packages need to be created first).

For new packages a manual push is required.

I've pushed a 88.1.3 build of chromiumembeddedframework.runtime.win-arm64 just now.