search

cegme / cs5293sp22

My class workspace.
MIT License
1 stars 48 forks source link

Multiple redactions in a single row #102

Open cegme opened 2 years ago

cegme commented 2 years ago

Words with multiple redactions made it into the data set. Please fix it ASAP. You will need to fix these issues to get full credit

adityakasturi8 commented 2 years ago

Removed the multiple redaction in line 1663 and updated a new pull request. Thank you.

nathanscain commented 2 years ago

There are more instances of this than those listed above:

@zwben lines 415 and 426 @minhtriet136 lines 784 and 785 @RamRao lines 813, 835, 870, 873, and 876 @bhargavvummadi line 1163 @adityakasturi8 line 1786 @CurSpace line 2440 @SaiPrakash1997 line 2633 @Gnan58 line 2918 @pinn0002 lines 2982, 2997, 3031, and 3057 @kaustubhpande73 line 3284 @VarshithaCVasireddy lines 3638 and 3674

cegme commented 2 years ago

Thanks. We'll try and keep track of updates.

cegme commented 2 years ago

@cegme. I believe it is a wrong tag. My lines are between line 1625 - line 1715

From line 1716 - 1804 it is @Aditya-Rohan-Singh .

In the latest, This is line 1786

adityakasturi8  validation  Tobel Basil Rathbone and Nigel Bruce return as Sherlock Holmes and Dr. Watson in this superior tale of Holmes battling the 3rd Reich and the mastermind genius of Professor Moriarty. The film opens up in Switzerland as Holmes is in disguise as an "old bookseller." He must bring Dr. █████ and the Bomb Site to England before the Germans can kidnap. Holmes succeeds and the Germans recuit the evil Professor. Moriarty manages to outwit Scotland yard and LeStrad "Dennis Hoey" by kidnapping █████. The only clue left by is a list of "dancing men." Who will break the hidden code of dancing men,
adityakasturi8 commented 2 years ago

My Apologies. I did not upstream, I have fixed the mentioned, and created a new pull request. Thank you!

bhargavvummadi commented 2 years ago

I have fixed that line and added new data, and created a new pull request. Thank you!

VarshithaCVasireddy commented 2 years ago

I fixed the issues in pull request #133. Please check them.

ramrao0102 commented 2 years ago

Hello,

Mine are not 2 separate redactions. They are the same redacted name that shows up twice in a sentence. You want them redacted, otherwise the label will end up in the sentence. Please check them.

cegme commented 2 years ago

@ramrao Each context should only have one redaction. It is fine if a redacted word is repeated in redacted in the context.

ramrao0102 commented 2 years ago

ok, so then I can change. How do I submit? Do I download the file, replace the 2 lines and resubmit a pull request?

cegme commented 2 years ago

ok, so then I can change. How do I submit? Do I download the file, replace the 2 lines and resubmit a pull request?

@ramrao0102 yes. unredact the extra redactions