search

cegme / cs5293sp22

My class workspace.
MIT License
1 stars 48 forks source link

Added Tashfeen's 90 records (50 training + 30 validation + 10 test) #111

Closed simurgh9 closed 2 years ago

simurgh9 commented 2 years ago

Hope everything looks okay.

simurgh9 commented 2 years ago

By context do you mean make the lines a bit longer?

And okay.

Sent from ProtonMail for iOS

On Sat, May 7, 2022 at 23:31, Christan Grant @.***> wrote:

@cegme requested changes on this pull request.

File format looks fine. Consider adding more context to the word entries so, they are more identifiable. Someone submitted before you. Please re-request a review

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

cegme commented 2 years ago

By context do you mean make the lines a bit longer?

Yes, it will help with the prediction. But, I will still accept your submission if you rather not make it longer.

simurgh9 commented 2 years ago

I will still accept your submission if you rather not make it longer.

Than I'll just re-request a review for now since I am chasing the clock a little bit. If I got more time towards the tail-end of this project, I'll make the lines bigger. Thanks Dr. Grant!

simurgh9 commented 2 years ago

Okay I have synced my fork. Could you merge this now?