Open dbwiddis opened 3 years ago
This is another reason for a better/more flexible versioning system than having a separate enum value for every iteration. I'm hoping to get on that in the next couple of days. Thanks a lot for the info and resources!
On the theme of WIndows version numbers needing build numbers, and on the heels of #4 which was the first to release a version "11" under a "10" label... Windows 11 can also show up as WIndows 10 with a build number of 22000+. So this particular issue should probably take a higher priority now. :)
The current implementation only includes "NT Workstation" (e.g., personal) versions and doesn't work for Windows Server versions. See JDK Source for a list of possible values for the
os.name
property.There are a few tricky points to consider here:
isAtLeast()
checks based on enum ordering; indicating perhaps we should be keeping major/minor available for this check. But that's hard without exposing it to the API.isAtLeast()
the existing enum ordering is sufficient and we should just add the server versions as equivalent case staements, e.g., map "server 2008" to "vista" and so on, and consider Server 2016 and Server 2019 equivalent.