search

cehfisher / a11y-style-guide

Accessibility (A11Y) Style Guide
http://a11y-style-guide.com/style-guide
MIT License
558 stars 61 forks source link

Webfonts should not be defined in pixels #228

Open nico3333fr opened 6 years ago

nico3333fr commented 6 years ago

Issue

Use em/rem/whatever but not pixels for font-size declarations for the website a11y-style-guide.

Example

I've noticed some #kss-node .kss-description h3 defined in pixels and other examples. You should defined them in em or rem.

Cheers!

cehfisher commented 6 years ago

I am using the theme I created to override those elements. This allows me to easily update KSS node when I need to, but keep my overrides in place.

nico3333fr commented 6 years ago

Wait, I'm not sure I understand: KSS overrides or your theme should override KSS?

px