ceholden / yatsm

Yet Another Time Series Model
https://yatsm.readthedocs.org/en/latest/
MIT License
63 stars 30 forks source link

Training script "labels" too generic & not utilized #64

Open ceholden opened 8 years ago

ceholden commented 8 years ago

Function get_training_inputs returns labels. These values are meant to be identification values for the pixel in the training data so that groups of pixels sharing the same label value can be grouped together for things like K-fold cross-validation. Currently, however, there are two problems:

  1. labels is too specific. The training data classification label, is a label, so this should be more specific to what it actually means
    • Could instead be, for example, roi_id, roi_label, etc.
  2. Nothing becomes of these labels! The SpatialKFold generators both use labels so that individuals from the same label are not mixed in the training / testing splits, but the labels are generated using scipy.ndimage.label instead of giving the user the ability to specify these labels via their ROI image.