ceifa / tiktoken-node

OpenAI's tiktoken but with node bindings
103 stars 10 forks source link

Support M1 Macs #5

Closed noseworthy closed 1 year ago

noseworthy commented 1 year ago

Include pre-built binary for tiktoken on Apple Silicon based macOS.

Should fix #2

Also opened up a PR here in case you want to use the PR started by @aarohmankad.

ceifa commented 1 year ago

Can you add the github workflow to publish the M1 build?

noseworthy commented 1 year ago

Ah, sorry @ceifa. Not super familiar with github workflows. I saw the step:

      - name: Upload artifact
        uses: actions/upload-artifact@v3
        with:
          name: OS specific binaries
          path: dist

And thought that since the artifact was already going to be in the dist directory, it'd get published.

ceifa commented 1 year ago

Ah, you are right.

ceifa commented 1 year ago

Hope that it doesn't include backdoors