Stricter compilation, more automation, fixed function memory leak

ceifa / wasmoon

A real lua 5.4 VM with JS bindings made with webassembly

MIT License

474 stars 29 forks source link

Stricter compilation, more automation, fixed function memory leak #12

Closed timstableford closed 3 years ago

timstableford commented 3 years ago

Added ESLint, more TypeScript rules, Prettier.
Made building the WASM part of the CI process. Made linting part of the CI process.
Functions were added without being removed so if you passed a function that returned another function on each call there would be leaks. This hooks the functions into Lua's garbage collection system.

Alternate version with the ESLint, Prettier and TS changes: https://github.com/ceifa/wasmoon/pull/11

ceifa commented 3 years ago

Thank you for the PR! I will take a look at these rules asap

timstableford commented 3 years ago

Thanks :) It's a cool project. I've got a few other things I'd like to PR too, feel welcome to be critical or otherwise let me know if I'm going a direction you don't like