ceifa / wasmoon

A real lua 5.4 VM with JS bindings made with webassembly
MIT License
462 stars 27 forks source link

Upgrade to angular 12 #41

Closed hansdpf closed 3 years ago

hansdpf commented 3 years ago

I was testing an upgrade to angular 12 in my project and got the following error messages:

If you want to include a polyfill, you need to:

./node_modules/wasmoon/dist/index.js:1507:20-33 - Error: Module not found: Error: Can't resolve 'fs' in '...\node_modules\wasmoon\dist'

How to solve the FinalizeRegistry problem?

I had this message - can't resolve fs, path, child_process.... - before, but with the "browser": {"fs": false, ...} entry in the package.json this message had disappeared; now with the upgrade test it has reappeared. Any hints?

ceifa commented 3 years ago

How to solve the FinalizationRegistry problem?

You reminded me that I needed to take the declaration out of it when typescript started supporting it out of the box. Just released a fix under 1.8.2 for this problem.

What about the polyfill and node.js module things?

Read the readme and try the "webpack" solution under the "Fixing common errors on web environment" section.