Change some functions to load the string on heap instead of stack

ceifa / wasmoon

A real lua 5.4 VM with JS bindings made with webassembly

MIT License

449 stars 29 forks source link

Change some functions to load the string on heap instead of stack #73

Closed ceifa closed 1 year ago

ceifa commented 1 year ago

Fixes #62

ceifa commented 1 year ago

@tims-bsquare @timstableford any thoughts on that?

timstableford commented 1 year ago

I think it's a good solution, though I think it's a shame emscripten doesn't automatically do this internally. In my ideal world you'd PR into their repo to fix it, but that may be more effort than it's worth