Fix patch version in unpkg url

ceifa / wasmoon

A real lua 5.4 VM with JS bindings made with webassembly

MIT License

449 stars 29 forks source link

Fix patch version in unpkg url #94

Closed gudzpoz closed 7 months ago

gudzpoz commented 8 months ago

Try to specify optional patch version in the unpkg url, removing any trailing labels (like -SNAPSHOT or whatsoever).

fix #93

ceifa commented 8 months ago

Why the regex is needed? The fix wouldnt be just put the raw version variable?

gudzpoz commented 8 months ago

I was wondering if the version string would include some extra suffixes as is specified by semver:

<valid semver> ::= ...
                 | <version core> "-" <pre-release> "+" <build>

But I guess the regex approach is still problematic since vernum1-SNAPSHOT will then rely on a published vernum1 version... Anyway, I've updated to simply use the raw version string. Thank you!

ceifa commented 7 months ago

Build is broken because of a bug on emscripten: https://github.com/emscripten-core/emscripten/pull/20726

ceifa commented 7 months ago

Merging it because the main is fixed and should build just great