ceisenach / screenlogic_over_ip

IP Communications for Pentair ScreenLogic2
GNU General Public License v3.0
16 stars 2 forks source link

error in screenlogic_over_ip/Protocol_Document.pdf #4

Open keithpjolley opened 6 years ago

keithpjolley commented 6 years ago

There's an error in the parameters of the Local Login Message, Section 5.1.1. The fourth bullet is incorrect.

Not correct:

Correct:

Also correct, for an empty password:

As shown:

localhost:60090-gateway:00080:
0000: 0000 1b00 2c00 0000 5c01 0000 0000 0000 0700 0000 416e 6472 6f69 6400 0000 0000  ....,...\...........Android.....
0020: 0000 0000 0000 0000 0000 0000 0000 0200 0000                                     ..................

gateway:00080-localhost:60090: 
0000: 0000 0d00 0000 0000  ........

Note that the gateway returns 13 (x0D) which I suppose is an error code.

With changes:

localhost:65510-gateway:00080:
0000: 0000 1b00 2c00 0000 5c01 0000 0000 0000 0700 0000 416e 6472 6f69 6400 1000 0000  ....,...\...........Android.....
0020: 0000 0000 0000 0000 0000 0000 0000 0000 0200 0000                                ....................

gateway:00080-localhost:65510:
0000: 0000 1c00 0000 0000  ........

Now the gateway returns 28 (x1C, x1B+1)

^according to my minimal testing

ceisenach commented 5 years ago

Thanks for pointing this out. I will look into it more and update the protocol document accordingly