search

cejug / hurraa

Opensource project to resource management
GNU General Public License v2.0
16 stars 18 forks source link

Crud equipment validation #107

Closed emanuelmm closed 10 years ago

emanuelmm commented 10 years ago

To complete the issue #46

paulojribp commented 10 years ago

Great @emanuelmm . @efraimgentil can you validate and merge if it's ok?

efraimgentil commented 10 years ago

Going to check it now

efraimgentil commented 10 years ago

Hi, @emanuelmm

I have seen some problens in the request, some o then don't need to be corrected, like the date format for the date's field's (#75 should handle that), and css for the form it can also be solved later.

But those listed bellow need to be solved so we can accept the pool:

  1. The fields serialId, endOfWarranty and lastMaintenance have the constrains not null but are not validated as it
  2. lastMaintenance field don't need to have not null constrains

Those are needed so we don't face exceptions while using the crud.

emanuelmm commented 10 years ago

Hi, @efraimgentil Ok... the first point will be resolved when we close issue #75... great! I will close this PR and i will create other PR to resolve the others questions. TY!