search

cekit / behave-test-steps

MIT License
0 stars 22 forks source link

Overhaul instantiating docker API class #57

Closed jmtd closed 6 months ago

jmtd commented 6 months ago

Don't pin docker APIClient to version 1.22.

Don't try to instantiate docker.Client before trying docker.APIClient: the former dates from the days the library was called "docker-py", the last release for which was November 2016. EPEL 7 and onwards provide the newer Python docker library, so I doubt there's anyone left using the older one.

This now aligns with Cekit.

(I'm still running local tests against this now)

jmtd commented 6 months ago

My local run (against ubi8/openjdk-11) worked.

rnc commented 6 months ago

Looks good thanks. Can you add an issue (not sure whether best here or in cekit) to update the hardcoded version to use CEKits for the next release?

jmtd commented 6 months ago

Looks good thanks. Can you add an issue (not sure whether best here or in cekit) to update the hardcoded version to use CEKits for the next release?

Sure, I think here is better. #59