cekit / behave-test-steps

MIT License
0 stars 21 forks source link

Correct branch specify for GH Actions #58

Closed rnc closed 4 months ago

rnc commented 4 months ago

@jmtd This keeps hanging - do you know why?

jmtd commented 4 months ago

We experience the exact same problem in the OpenJDK repo. I don't know why it's hanging but I did narrow it down to with which command the hang is occurring. the docker library function exec_start sometimes never returns. Their docs imply it's subject to a default API timeout but that isn't taking effect.

I've got a branch that we use to try and improve things where I fork before calling exec_start and watchdog that from the parent process. It doens't fix it , but it means the test that's wedged times out and doesn't stop the whole test run.

https://github.com/cekit/behave-test-steps/compare/v1...jmtd:behave-test-steps:v1

We've been running with this for a while so perhaps I should raise a PR.

jmtd commented 4 months ago

oh it's worth configuring the GHA timeout to be much lower than the default (6 hours?) too: https://github.com/jboss-container-images/openjdk/blob/ubi9/.github/workflows/image-workflow-template.yml#L13