search

cekit / behave-test-steps

MIT License
0 stars 21 forks source link

container.execute: fix when exec_start completes fast #60

Closed jmtd closed 3 months ago

jmtd commented 3 months ago

p.join will return None in two situations: when the timeout is reached, and if the process has completed already.

Adjust the check so that we throw an exception in the former case but not the latter.

This hopefully fixes a reported error in running the test suite for https://github.com/wildfly/wildfly-s2i/actions/runs/8345796441/job/22876447353#step:16:2666

For this wishing to test this: at the moment https://github.com/jmtd/behave-test-steps branch v1 has this patch.

jmtd commented 3 months ago

Confirmation that this fixed wildfly: https://github.com/wildfly/wildfly-s2i/pull/464

rnc commented 3 months ago

@jmtd If this confirms the issue, are you merging it ?

jmtd commented 3 months ago

@rnc I seem to lack permission to merge it myself. I was hoping to learn whether this also addressed https://github.com/cekit/cekit/issues/903 , but I think fixing wildfly's test runs is probably sufficient to merge it.

rnc commented 3 months ago

@jmtd I've modified your permissions.