search

celaxodon / buildroot

Other
20 stars 6 forks source link

Update jetson_nano_defconfig to honor BR2_EXTERNAL #1

Closed kmoughon closed 3 years ago

kmoughon commented 3 years ago

Adds support for users who want to use BR2_EXTERNAL options with this defconfig. Simple variable addition before the board/ directory so the path is not locked to the default buildroot directory.

celaxodon commented 3 years ago

Thank you for the pull request! Unfortunately, this causes the build to fail if BR2_EXTERNAL is not set. I also notice that none of the other board configs have this variable substitution, and so I am hesitant to include it. I am glad it works for your use case, however.

I'm always excited to hear about Buildroot and NVIDIA boards, and if you have use cases in mind I'd be very interested to hear about them. If you can talk about them but prefer to communicate privately, feel free to reach me at gleva [at] nvidia [dot] com.

kmoughon commented 3 years ago

interesting, I'm new to buildroot and this substitution was only way I could get it to honor the customizations I made to your base stuff when using the BR2_EXTERNAL methods and mimicking the board/nvidia/... file structure in my external directory. I did run one quick test without the BR2_EXTERNAL set and it worked for me but I'm still learning the basics of buildroot.

celaxodon commented 3 years ago

I admit I haven't worked with BR2_EXTERNAL trees much yet. I've been working towards support for the Nerves project, which uses BR2_EXTERNAL trees for tying in Elixir/Erlang and some other customizations. You can see an example here. Maybe it will help some or give you ideas?