search

celebi-pkg / flight-analysis

Python package to scrape flight data from Google Flights and analyzes prices. Can determine optimal flight from date, place, and price
https://kcelebi.github.io/flight-analysis/
MIT License
127 stars 38 forks source link

string to float error #3

Closed smyja closed 1 year ago

smyja commented 1 year ago

when i run the example, i get this error.

price += [float(g[8 + i_diff][1:].replace(',',''))]
ValueError: could not convert string to float: 'GN 365873'
kcelebi commented 1 year ago

I've made a bunch of changes in the parser to fix this and some other errors. I will close this issue once v1.1.0 is released, which should be soon.

smyja commented 1 year ago

I've made a bunch of changes in the parser to fix this and some other errors. I will close this issue once v1.1.0 is released, which should be soon.

Great, I've fixed it on my end also.

kcelebi commented 1 year ago

Version 1.1 out now, pushed the newest changes to the main branch. Let me know if any other issues come up!