celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
62 stars 34 forks source link

Fix single-precision soft equivalence for plane #1139

Closed sethrj closed 7 months ago

sethrj commented 7 months ago

This adds documentation to and fixes the soft equivalence function for planes. Due to the comparisons using $\epsilon^2$, a tolerance of 1e-4f can get washed out in the machine precision error which is larger than 1e-8f.

I have also uninlined LocalSurfaceInserter::operator() to reduce code size.

This also fixes the extra semicolon in ConvexSurfaceBuilder that @stognini reported, and the missing -Werror that allowed that to pass the CI.