search

celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
62 stars 33 forks source link

Improve gentrap documentation and fix typos #1205

Closed mrguilima closed 5 months ago

mrguilima commented 5 months ago

Since the input lower points can be ordered in both CW or CCW orderings, the sense needs to take into account the sign of the plane offset with respect to the plane normal.

An extra test was added for opposite ordering of points (CCW ordering), and the documentation has been adjusted.

See review process for descriptions of the labels and requirements.

sethrj commented 5 months ago

@mrguilima Maybe some additional restrictions are needed on the points input to the gentrap. For example, are there restrictions about the top and bottom points not being rotated 180 degrees?

Screenshot 2024-04-25 at 18 49 23
sethrj commented 5 months ago

@mrguilima Actually it looks like the problem is that the normal calculation assumes the points are CCW ... which is not the case.