Closed sethrj closed 2 months ago
@mrguilima I've removed the validation checking from phi:
If the value were part of the shape's data, we should regularize it so that there's a one-to-one correspondence between values and shapes produced. However, since phi just gets preprocessed into the same points, there's no need to impose extra effort on the user (e.g. it's ok if they want to specify the rotation as 3/4 turn instead of -1/4 turn).
Is the proposed removal of validation satisfactory @mrguilima ?
Yes, it looks good! Thanks
Thanks to @mrguilima for pointing out that there was an error in the calculation.
Also fixes https://github.com/celeritas-project/celeritas/pull/1223#discussion_r1592931865 .