celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
58 stars 32 forks source link

Fix trapezoid construction for negative phi and older Geant4 #1227

Closed sethrj closed 2 months ago

sethrj commented 2 months ago

Thanks to @mrguilima for pointing out that there was an error in the calculation.

Also fixes https://github.com/celeritas-project/celeritas/pull/1223#discussion_r1592931865 .

sethrj commented 2 months ago

@mrguilima I've removed the validation checking from phi:

If the value were part of the shape's data, we should regularize it so that there's a one-to-one correspondence between values and shapes produced. However, since phi just gets preprocessed into the same points, there's no need to impose extra effort on the user (e.g. it's ok if they want to specify the rotation as 3/4 turn instead of -1/4 turn).

sethrj commented 2 months ago

Is the proposed removal of validation satisfactory @mrguilima ?

mrguilima commented 2 months ago

Yes, it looks good! Thanks