search

celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
62 stars 33 forks source link

Regularize quadric surfaces to deduplicate opposing surfaces #1237

Closed sethrj closed 4 months ago

sethrj commented 4 months ago

This fixes one of the two issues that could get in the way of deduplicating twisted surfaces. The sign of quadric equations are now regularized so that two opposite-signed quadric surfaces become the same quadric surface but with a flipped sense. The quadrics are also scaled so that the largest coefficient is 1. We don't do any scaling yet because that seems to affect the accuracy of the calculation...

sethrj commented 4 months ago

Ping @elliottbiondo / @mrguilima

sethrj commented 4 months ago

@mrguilima It looks like you keep somehow reviewing "partial" merge requests; please confirm that the upper left of the review box looks like this:

Screenshot 2024-05-18 at 07 20 50

and not like this:

Screenshot 2024-05-18 at 07 20 08

This is why you've been having trouble making code suggestions.

I left the review open for several days with no response; if I ping for a review and someone else reviews it, please just leave a message saying you're still working on it. After the merge goes in, if you find errors in the documentation, please feel free to open a new pull request with the desired changes.

mrguilima commented 4 months ago

Yeah, sometimes I feel like I am doing something not quite right... Thanks for the suggestion, I will keep an eye on it.