search

celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
58 stars 32 forks source link

Rename ConvexRegion to IntersectRegion #1245

Closed sethrj closed 1 month ago

sethrj commented 1 month ago

After implementing twisted faces (#1232 ) the convex region is incorrectly named: it's really a conjunction (intersection) of half-spaces rather than a convex region. The important thing is that crossing any surface exits the region, and the nearest distance to any surface is the nearest distance to the region's boundary.

I've therefore renamed ConvexRegion to IntersectRegion. I considered "conjunctive" , "intersection", and "isect", and think this is the best combination of clear, correct, and concise.

mrguilima commented 1 month ago

Is it true that Shapes are meant to be convex, and Solids may be made of unions of Shapes? If so, and once this concept is well explained, maybe the ConvexRegion could be renamed as a ShapeRegion? Just a suggestion, in case you're not so happy with your choice of IntersectRegion.