search

celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
58 stars 32 forks source link

Fix CSG tree simplification needed by tilecal #1256

Closed sethrj closed 4 weeks ago

sethrj commented 1 month ago

The ATLAS tile calorimeter raytrace is having some problems. The first one I identified by simplifying a detector until it was a couple of cylinder segments. Previously this failed to raytrace while crossing the inner cylinder's surface (from left to right): image

This is the original CSG tree graph, where "16" is "outside TileTBEnv" and set to false: tilecal-bug-0.pdf Originally this simplified to: tilecal-bug-2.pdf which did not eliminate the inner cylinder surface 3 (which can be proven 'true' by being inside tiletbenv) due to early replacement of a node. Now it's fixed: tilecal-bug-1-fixed.pdf

Unfortunately although the raytrace for tilecal has fewer errors, there's still a problem:

image

sethrj commented 4 weeks ago

@elliottbiondo Please don't forget this one either!

elliottbiondo commented 4 weeks ago

@sethrj sorry, I actually reviewed this Tuesday night, but I accidentally left my one minor comment as "pending".