celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
62 stars 33 forks source link

Fix trapezoid construction #1265

Closed sethrj closed 3 months ago

sethrj commented 3 months ago

I introduced an error in #1221 when I forgot to complete the change from "tan_alpha" to "alpha". This completes the conversion so the trapezoid face input is specified as an angle rather than a tangent.

The "sampling" test I added to the solid converter also fails on the EMEC G4GenericTrap due to a separate issue to be resolved in a further pull request. For now I am skipping that one failure.