celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
62 stars 33 forks source link

Support degenerate faces for "GenTrap" and rename to GenPrism #1271

Closed sethrj closed 2 months ago

sethrj commented 3 months ago

This adds support for degenerate (coincident or collinear) points in a GenTrap allowing for tetrahedra, or pentahedra (the top face being a line). There's no reason to limit the number of points on the top or bottom face; they can each be arbitrary convex polygons. (We should for example be able to make a twisted hexagonal prism.) Thus I suggest renaming this class to GenPrism. It's more like an extruded and warped polygon... but I think that encapsulates the typical use cases.

sethrj commented 2 months ago

Ping @mrguilima