celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/user/index.html
Other
58 stars 32 forks source link

Add optical sub-namespace #1314

Open hhollenb opened 2 weeks ago

hhollenb commented 2 weeks ago

Add the sub-namespace celeritas::optical to help separate core and optical code. Most files and classes prefixed with Optical were renamed to either not include the prefix, or use a more descriptive prefix. Added the prefix PreGen to classes and files used by the Cerenkov and Scintillation pre-generators to specify they're in-between core and optical physics.

It may be worth adding a celeritas::core sub-namespace to ensure there's no ambiguity between similarly named types.

sethrj commented 1 week ago

@amandalund I'll let you review and merge this one?

hhollenb commented 10 hours ago

Naming convention changes after the recent commits:

There's some classes which live at the interface of core and optical. In general I place them inside the optical namespace, but I don't have a particular preference.