search

celeritas-project / celeritas

Celeritas is a new Monte Carlo transport code designed to accelerate scientific discovery in high energy physics by improving detector simulation throughput and energy efficiency using GPUs.
https://celeritas-project.github.io/celeritas/
Other
65 stars 35 forks source link

Fix dBVH memcpy size #1490

Closed esseivaju closed 2 weeks ago

esseivaju commented 2 weeks ago

Introduced in #1481, copy the entire pointer instead of 1 byte.

github-actions[bot] commented 2 weeks ago

Test summary

 3 386 files   5 238 suites   3m 53s :stopwatch:  1 583 tests  1 555 :white_check_mark: 28 :zzz: 0 :x: 17 458 runs  17 392 :white_check_mark: 66 :zzz: 0 :x:

Results for commit 60675990.

esseivaju commented 2 weeks ago

Missed that in the review, better late than never 😅

pcanal commented 2 weeks ago

Does it fix the crash related to dBVH?

sethrj commented 2 weeks ago

This was only for the diagnostic. Sorry I didn't notice it!

esseivaju commented 2 weeks ago

right, it's only for the diagnostic, and that line is still showing up in a full static build of AthSimulation+AthExternals