search

celerity / celerity-runtime

High-level C++ for Accelerator Clusters
https://celerity.github.io
MIT License
139 stars 18 forks source link

Include fmt headers directly rather than through spdlog #228

Closed fknorr closed 9 months ago

fknorr commented 9 months ago

We pulling in fmt as an explicit dependency, but are including its headers through <spdlog/fmt>. I was briefly confused how this was even compatible, but as it turns out spdlog takes care of transitively including the right headers if it was built with an external fmt implementation (as ours is).

Nevertheless, I've taken the opportunity to include the correct headers directly in our code to make things less confusing.

This also gets rid of two iostreams includes, so this is of course very dear to my heart ;)

github-actions[bot] commented 9 months ago

Check-perf-impact results: (3b34e58e3c100f4c3541a1ed59580f72)

:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.