celerity / celerity-runtime

High-level C++ for Accelerator Clusters
https://celerity.github.io
MIT License
139 stars 18 forks source link

Remove buffer_manager / runtime dependency from some accessor tests #231

Closed fknorr closed 7 months ago

fknorr commented 9 months ago

This is a back-port from IDAG development.

There are some tests for accessors that used to logically depend on full runtime or at least a buffer_storage / the buffer manager before we switched to USM buffers, but don't anymore. One test that should have used the runtime directly had been re-written to use the buffer manager to work around a ComputeCpp compiler bug, which now is not a concern anymore either.

This PR pulls out pure accessor tests from buffer_manager_tests and makes them runtime-independent where possible in anticipation of buffer_manager's removal with the switch to IDAG scheduling.

github-actions[bot] commented 9 months ago

Check-perf-impact results: (4c65f1399a47e0eb1340f63004745b17)

:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7774971382


Totals Coverage Status
Change from base Build 7727056751: 0.09%
Covered Lines: 4995
Relevant Lines: 5187

💛 - Coveralls