celerity / celerity-runtime

High-level C++ for Accelerator Clusters
https://celerity.github.io
MIT License
141 stars 18 forks source link

Tests: Do not value-capture buffers in host-tasks #244

Closed fknorr closed 8 months ago

fknorr commented 8 months ago

This fix is a backport from IDAG development.

Value-capturing a buffer lifetime-extends it such that its destructor may be called from the executor thread. This is already disallowed on the API side but not detected, and it is also not forward-compatible with lifetime management post-instruction-graph, where it was discovered.

github-actions[bot] commented 8 months ago

Check-perf-impact results: (4c65f1399a47e0eb1340f63004745b17)

:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.