Closed fknorr closed 1 month ago
github-actions[bot]
commented
2 months ago Check-perf-impact results: (7b849de16ff11660b98988ab0b032db7)
:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.
coveralls
commented
2 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| include/device_selection.h | 99 | 100 | 99.0% | ||
| include/utils.h | 8 | 9 | 88.89% | ||
| <!-- | Total: | 107 | 109 | 98.17% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/task.cc | 1 | 87.58% | ||
| include/device_queue.h | 65 | 39.23% | ||
| <!-- | Total: | 66 | --> |
| Totals | |
|---|---|
| Change from base Build 9549035557: | -1.2% |
| Covered Lines: | 7095 |
| Relevant Lines: | 7376 |
coveralls
commented
1 month ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| include/device_selection.h | 99 | 100 | 99.0% | ||
| include/utils.h | 8 | 9 | 88.89% | ||
| <!-- | Total: | 107 | 109 | 98.17% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| include/device_queue.h | 65 | 39.23% | ||
| <!-- | Total: | 65 | --> |
| Totals | |
|---|---|
| Change from base Build 9661291153: | -1.1% |
| Covered Lines: | 7095 |
| Relevant Lines: | 7375 |
This upstreams the new device selection logic developed by @psalz for the old multi-GPU Celerity branch alongside modifications I made for the new IDAG backend logic.
While the old single-device selection logic remains in place until the IDAG execution PR, its tests are already replaced here to streamline the merge process.