Closed fknorr closed 2 months ago
github-actions[bot]
commented
2 months ago Check-perf-impact results: (7b849de16ff11660b98988ab0b032db7)
:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.
coveralls
commented
2 months ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| include/grid.h | 1 | 96.81% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9549035557: | -0.02% |
| Covered Lines: | 7053 |
| Relevant Lines: | 7267 |
coveralls
commented
2 months ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/task.cc | 1 | 87.58% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9549035557: | -0.009% |
| Covered Lines: | 7054 |
| Relevant Lines: | 7268 |
fknorr
commented
2 months ago 🍰
coveralls
commented
2 months ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| include/grid.h | 1 | 96.81% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9549035557: | -0.02% |
| Covered Lines: | 7053 |
| Relevant Lines: | 7265 |
This fixes a test by @PeterTh that got broken when epochs were introduced: The task manager must delete tasks behind the effective-epoch, and that condition was awaited in the main thread through
slow_full_sync(). That function however inserts an epoch which force-deletes all tasks before it, making the test pass even if horizons never delete tasks at all.This PR replaces the calls to
slow_full_sync()with manual synchronization to ensure we still test the actual horizons behavior.