celerity / celerity-runtime

High-level C++ for Accelerator Clusters
https://celerity.github.io
MIT License
139 stars 18 forks source link

[IDAG] Pre-Execution Refactoring #260

Closed fknorr closed 1 month ago

fknorr commented 2 months ago

This PR performs some small refactorings necessary for me to introduce the new executor- and backend types in another standalone PR without replacing the entire runtime. It is best reviewed per commit.

  1. The additional members attached to device-kernel / host-task instructions for bounds checking now also include the task type, which will improve the quality of diagnostic messages.
  2. Instructions and outbound pilots are flushed from the IGGen in batches instead of individually, which reduces the frequency with which an implementor of the delegate (= the executor) needs to take locks to move this info to their thread.
  3. accessor and closure_hydrator::accessor_info now refer to "allocations" and "buffers" instead of "virtual" and "backing buffers", and the bounds-checking is improved from using simple arrays to a proper struct.
  4. host_task_launcher (currently only used as a placeholder) now is independent of host_queue, which will disappear soon.
  5. As the names backend and executor will be re-used, these namespaces / components are renamed to legacy_backend and legacy_executor in the meantime so they can stick around for the next PR.
github-actions[bot] commented 2 months ago

Check-perf-impact results: (7b849de16ff11660b98988ab0b032db7)

:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9725828007

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
include/device_queue.h 2 3 66.67%
src/instruction_graph_generator.cc 5 6 83.33%
src/legacy_executor.cc 6 7 85.71%
include/legacy_backend/backend.h 3 7 42.86%
<!-- Total: 87 94 92.55% -->
Totals Coverage Status
Change from base Build 9661291153: -0.009%
Covered Lines: 7048
Relevant Lines: 7261

💛 - Coveralls