Closed fknorr closed 1 month ago
Check-perf-impact results: (7b849de16ff11660b98988ab0b032db7)
:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
include/device_queue.h | 2 | 3 | 66.67% | ||
src/instruction_graph_generator.cc | 5 | 6 | 83.33% | ||
src/legacy_executor.cc | 6 | 7 | 85.71% | ||
include/legacy_backend/backend.h | 3 | 7 | 42.86% | ||
<!-- | Total: | 87 | 94 | 92.55% | --> |
Totals | |
---|---|
Change from base Build 9661291153: | -0.009% |
Covered Lines: | 7048 |
Relevant Lines: | 7261 |
This PR performs some small refactorings necessary for me to introduce the new executor- and backend types in another standalone PR without replacing the entire runtime. It is best reviewed per commit.
accessor
andclosure_hydrator::accessor_info
now refer to "allocations" and "buffers" instead of "virtual" and "backing buffers", and the bounds-checking is improved from using simple arrays to a proper struct.host_task_launcher
(currently only used as a placeholder) now is independent ofhost_queue
, which will disappear soon.backend
andexecutor
will be re-used, these namespaces / components are renamed tolegacy_backend
andlegacy_executor
in the meantime so they can stick around for the next PR.