celerity / celerity-runtime

High-level C++ for Accelerator Clusters
https://celerity.github.io
MIT License
139 stars 18 forks source link

Fix graph printing in TDAG / CDAG generation tests #262

Closed fknorr closed 1 month ago

fknorr commented 1 month ago

Previously with --print-graphs, dot graphs were written to the log inside TDAG / CDAG tests, but test logs are captured and discarded on success since #234, breaking this command-line option.

This PR updates TDAG / CDAG tests to write dot graphs to stdout like already done for IDAG tests. Test names are included in the dot title, and no additional context information is printed alongside. The user / developer is expected to invoke test executables with render-graphs.py.

While at it, I've taken the opportunity to rename test_utils::print_graphs to g_print_graphs to highlight that it's an unprotected global.

github-actions[bot] commented 1 month ago

Check-perf-impact results: (7b849de16ff11660b98988ab0b032db7)

:question: No new benchmark data submitted. :question:
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10006864064

Details


Totals Coverage Status
Change from base Build 9992874606: -0.009%
Covered Lines: 7231
Relevant Lines: 7507

💛 - Coveralls