celerity / celerity-runtime

High-level C++ for Accelerator Clusters
https://celerity.github.io
MIT License
139 stars 18 forks source link

[IDAG] Switch to Instruction-Graph Scheduling #265

Closed fknorr closed 1 month ago

fknorr commented 1 month ago

This is the final PR in the IDAG series. It switches to the new IDAG-based runtime and drops all newly unused legacy components.

new runtime architecture

Since one node now addresses multiple GPUs, scheduling becomes more expensive (IDAG generation is maybe ~4x as expensive as CDAG generation). This will be visible in benchmark results.

github-actions[bot] commented 1 month ago

Check-perf-impact results: (877795252c9a57f7b343e4747db6ca4f)

:warning: Significant slowdown (>1.25x) in some microbenchmark results: 7 individual benchmarks affected
:heavy_plus_sign: Added microbenchmark(s): 48 individual benchmarks affected
:heavy_minus_sign: Removed microbenchmark(s): 48 individual benchmarks affected

Relative execution time per category: (mean of relative medians)

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10213951594

Details


Files with Coverage Reduction New Missed Lines %
src/task.cc 1 92.06%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10143808743: 1.8%
Covered Lines: 6564
Relevant Lines: 6700

💛 - Coveralls
github-actions[bot] commented 1 month ago

Check-perf-impact results: (f2e639c8a97550e58528a410c1b8586d)

:warning: Significant slowdown (>1.25x) in some microbenchmark results: 8 individual benchmarks affected
:heavy_plus_sign: Added microbenchmark(s): 48 individual benchmarks affected
:heavy_minus_sign: Removed microbenchmark(s): 48 individual benchmarks affected

Relative execution time per category: (mean of relative medians)

Edit: We inadvertently disabled mimalloc. All hail the benchmark suite!

github-actions[bot] commented 1 month ago

Check-perf-impact results: (2908f97f836fd2def14c3429cd4d61ac)

:warning: Significant slowdown (>1.25x) in some microbenchmark results: 5 individual benchmarks affected
:rocket: Significant speedup (<0.80x) in some microbenchmark results: generating large command graphs for N nodes - 1 / chain topology
:heavy_plus_sign: Added microbenchmark(s): 48 individual benchmarks affected
:heavy_minus_sign: Removed microbenchmark(s): 48 individual benchmarks affected

Relative execution time per category: (mean of relative medians)