search

celery / billiard

Multiprocessing Pool Extensions
Other
419 stars 252 forks source link

#296 Add job id to WorkerLostError message #317

Closed ThomasWunderlich closed 4 years ago

ThomasWunderlich commented 4 years ago

Ticket Id: #296 This adds a job id to the WorkerLostError error message so that it's easier to figure out which job was killed with a worker lost.

Alternatively, if you don't want to change the exception message I can add this as a separate debug message

ThomasWunderlich commented 4 years ago

@auvipy, The pypy2 failures are due to the current version of psutil not supporting pypy2. See https://github.com/giampaolo/psutil/issues/1659 I'll see if I can update tox.ini with the workaround mentioned in the aforementioned link.

auvipy commented 4 years ago

can we pin psutils for now?

ThomasWunderlich commented 4 years ago

@auvipy Apologies for the delay. I've pinned psutil to the last known good version for pypy2 and added a message to clarify why it's pinned. This should be good to review now

auvipy commented 4 years ago

https://github.com/celery/billiard/pull/318