search

celery / jumpstarter

MIT License
7 stars 3 forks source link

Resolve double start #20

Closed ahopkins closed 3 years ago

ahopkins commented 3 years ago

This resolves the ability to transition from stopped state to started state with a single .start() trigger.

thedrow commented 3 years ago

I just ran the test myself without these changes and you're 100% right. There is a bug and this PR fixes it but I still don't understand why.

thedrow commented 3 years ago

I fixed the root cause of the issue in c718a19. I think having an Enum for the triggers is a good idea and I'd welcome a PR that adds that to our codebase. I just think that it makes it harder to understand what's the bugfix and what's a new enhancement if they are in the same commit. @ahopkins I'm not deleting this branch, feel free to do so yourself if you don't need it anymore.