search

celery / kombu

Messaging library for Python.
http://kombu.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
2.87k stars 930 forks source link

Integration tests are missing redis sentinel #1254

Open matusvalo opened 4 years ago

matusvalo commented 4 years ago

Integration tests are missing tests for SentinelChannel and 'sentinel://' connection string.

matusvalo commented 3 years ago

The following steps needs to be done:

  1. Dockerfile for redis with sentinel (ideally supporting SSL) needs to be added - see the example for rabbitmq in https://github.com/celery/py-amqp/blob/master/Dockerfile
  2. Tox needs to be updated to use the docker file as in py-amqp: https://github.com/celery/py-amqp/blob/c903aaeb581cc60bd1258df823a5a2a2a4ecdbd7/tox.ini#L34
  3. integration tests needs to be added for sentilen - see an example for py-amqp: https://github.com/celery/py-amqp/blob/master/t/integration/test_rmq.py