Open Kludex opened 2 years ago
Hey @Kludex :wave:, Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider backing us - every little helps!
We also offer priority support for our sponsors. If you require immediate assistance please consider sponsoring us.
Is there any priority? I can help with some of this tasks
Is there any priority? I can help with some of this tasks
Not really. Go ahead. 🙏
Is there any priority? I can help with some of this tasks
just avoid duplicated work, so checking open or closed PR will help to avoid that
Created a PR to no duplicate work
I didn't forget about this. I'm struggling with time. JFYK.
I was thinking of stubs instead of annotating the codes directly
Why?
Taking utils/debug.py
with https://github.com/celery/kombu/pull/1714 and utils/compat.py
with https://github.com/celery/kombu/pull/1715.
I was thinking of stubs instead of annotating the codes directly
Hi @auvipy,
I wanted to continue working on type hints for kombu
and celery
(preferably kombu
first as celery
is built on top of it).
Are you still open to have type hints directly in both projects? I can understand the drawbacks of having them in the source code (can block people contributing, extra CI checks, extra review for PRs adding typing), although there are benefits of having them builtin in the source code instead of stubs (never gets out of sync, readability for users of the library).
If this is the case, I'd like to offer three things:
from __future__ import annotations
, typing_extensions
, etc.
Fully Type Annotation - Kombu
Analogous to https://github.com/celery/celery/issues/7394.
:white_check_mark: (
:white_check_mark:
): Merged :x: (:x:
): Need work :speech_balloon: (:speech_balloon:
): In reviewReport generated from
mypy kombu --txt-report .
(04/05/2022):