celery / kombu

Messaging library for Python.
http://kombu.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
2.91k stars 929 forks source link

CurlClient isn't used anymore and probably could be deleted #1537

Closed dobosevych closed 1 month ago

dobosevych commented 2 years ago

CurlClient isn't used anymore and it is broken for a lot of time, so probably can be removedhttp/curl.py. There are several reasons for that

  1. It depends on pycurl that isn't in any dependencies, so on next code we will receive an error
    from kombu.asynchronous.http.curl import CurlClient
    c = CurlClient()
  2. I don't see any usage client CurlClient or Client in celery repo

In any case code could be at least cleaned

open-collective-bot[bot] commented 2 years ago

Hey @dobosevych :wave:, Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors. If you require immediate assistance please consider sponsoring us.

auvipy commented 2 years ago

it was scheduled to removed

auvipy commented 2 years ago

pycurl might have usage in kombu most probably

dobosevych commented 2 years ago

but it isn't in any dependencies already should I help with code cleaning?

auvipy commented 2 years ago

boto sqs?

dobosevych commented 2 years ago
pip install kombu
>>> from kombu.asynchronous.http.curl import CurlClient
>>> c = CurlClient()

will lead to an error. This I suppose should be fixed or cleaned. What is your suggestion?

auvipy commented 2 years ago

https://github.com/celery/kombu/issues/737 check this please

shadowrider17 commented 1 year ago

Why does kombu needs pycurl but doesn't specify this in requirements? Can someone please help with this. Thank you.

spawn-guy commented 1 month ago

check this out, please. https://github.com/celery/kombu/pull/2134 and see if it works for your needs (planned to be in v5.5)