search

celery / kombu

Messaging library for Python.
http://kombu.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
2.87k stars 928 forks source link

enhance: allow users to disable broker heartbeats #1998

Closed smart-programmer closed 4 months ago

smart-programmer commented 4 months ago

broker heartbeats clutter the logs console which prevents users from seeing important logs. this allows users to disable broker heartbeats if timeout isn't provided.

reference issue

FrankK-1234 commented 4 months ago

Hello,

I took the liberty to add a test case for this change. However I'm failing to add to a pull request as I'm new to git and I get a permission denied pushing to smart-programmer branch. No clue how to do it. I however attached a patch file to add the change in t/unit/test_mixins.py. Would that test case be enough for the proposed change? (I somehow cannot upload .patch so used .txt instead) test_mixins.txt

auvipy commented 4 months ago

thanks for the test! you have to open a PR on smart-programmer:enhance/disable-heartbeat-no-timeout branch. if you can't do that we will add the test from your provided code!

auvipy commented 4 months ago

Hello,

I took the liberty to add a test case for this change. However I'm failing to add to a pull request as I'm new to git and I get a permission denied pushing to smart-programmer branch. No clue how to do it. I however attached a patch file to add the change in t/unit/test_mixins.py. Would that test case be enough for the proposed change? (I somehow cannot upload .patch so used .txt instead) test_mixins.txt

or you can open a full PR with your tests and this PR's changes as well! we wil make sure both will get contributors credit

FrankK-1234 commented 4 months ago

I've create a new PR #2016 with both the change and the test case.