search

celery / py-amqp

amqplib fork
Other
308 stars 194 forks source link

Hard-code requests version because of the bug in docker-py #432

Closed awmackowiak closed 4 months ago

awmackowiak commented 4 months ago

Due to bug reported in decker-py there is a need to hard-code the requests version to <=2.31.0. 5 days ago they released the newest version and the integration tests started failures that day.

Nusnus commented 4 months ago

The bug is fixed in docker-py 7.1.0. I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

Nusnus commented 4 months ago

The bug is fixed in docker-py 7.1.0. I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py

Nusnus commented 4 months ago

The bug is fixed in docker-py 7.1.0. I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py

I am getting confused 4real… I’ve tried to follow up on my own comment: https://github.com/celery/py-amqp/pull/433 Nothing works, not even close.

I don’t like limiting requests, but we might not have any other choice at the moment, especially if this issue is relevant to fixing the Redis bug.

Nusnus commented 4 months ago

The bug is fixed in docker-py 7.1.0. I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py

I am getting confused 4real… I’ve tried to follow up on my own comment: #433 Nothing works, not even close.

I don’t like limiting requests, but we might not have any other choice at the moment, especially if this issue is relevant to fixing the Redis bug.

I also tried it with kombu, juts for the sake of seeing what happens. Same confusing results: https://github.com/celery/kombu/pull/2010

awmackowiak commented 4 months ago

@Nusnus I also tried to find a silver bullet for that problem but didn't find an easy way to get the test up and running. Kudos for the try :)