search

celeschai / pe

0 stars 0 forks source link

Able to add clashing classes without warning #10

Open celeschai opened 5 days ago

celeschai commented 5 days ago

image.png

According to this user story, user should be warned of clashing classes.

To replicate: add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 t/Sunday-1000-1200 s/Geography r/100 paid/100 owed/0

add n/Janey Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 t/Sunday-1000-1200 s/Geography r/100 paid/100 owed/0

Expected: User should be prevented / warned of the exactly clashing class,

Actual: Both students' classes were added without any issues.

image.png

soc-pe-bot commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Hi, noted that your bug report was about user was Able to add clashing classes without warning. We will reject this since there are actually warnings shown.

We will reject this bug report. We have tried to run these two commands: add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 t/Sunday-1000-1200 s/Geography r/100 paid/100 owed/0 add n/Janey Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 t/Sunday-1000-1200 s/Geography r/100 paid/100 owed/0

Running these two command does give a warning in the UGTeach. We are not very sure why you flagged the issue of add clashing classes without warning.
video:https://raw.githubusercontent.com/nus-cs2103-AY2425S1/pe/master/files/46b7866b-b8cc-47ff-8d60-7252779f63e0.mp4

Moreover, we felt that such clashing schedule should warned and not be prevented. Refer to the screenshot below from the course website.

image.png

We want to give the user the flexibility of deciding which student to change the schedule, instead of preventing the user from adding Janey Doe's tuition schedule into UGTeach just because John Doe has the same tuition schedule. Moreover, the clashing schedule notification should just serve as a warning, since the user's intention might be to conduct tuition for Janey Doe and John Doe together. (i.e. they are siblings who take tuition together)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]