search

celestiaorg / blobstream-contracts

Celestia -> EVM bridge
Apache License 2.0
130 stars 40 forks source link

fix!: bug of `verifyMultiRowRootsToDataRootTupleRoot` #307

Closed zhiqiangxu closed 6 months ago

zhiqiangxu commented 6 months ago

The original _root parameter is not verified before being used in verifyMultiRowRootsToDataRootTupleRootProof, it will allow arbitrary _rowRoots to be proved valid.

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The update in the code involves refining the function parameters in DAVerifier.sol to enhance data handling clarity. This change streamlines the usage of data references and improves consistency across related contracts.

Changes

File Path Change Summary
src/lib/verifier/.../DAVerifier.sol Modified parameter in verifyMultiRowRootsToDataRootTupleRoot function.
src/lib/verifier/test/.../DAVerifier.t.sol Removed fixture.dataRoot() argument from function calls.
src/lib/verifier/test/.../RollupInclusionProofs.t.sol Updated call to DAVerifier.verifySharesToDataRootTupleRoot.

Poem

🌟🐇 A CodeRabbit's Ode to Code 🐇🌟

In the warren of wires and code, A small change does brightly glow. From bytes32 roots we've boldly strode, To structured paths where data flows. Hop, skip, a leap in logic's abode, Crafted neatly in the coder's trove.

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between c92e4a1c92a239e85b33c2e247b704cfab6efe4a and f62ca0eb54c8432b09fcd6b79cb284a22679d449.
Files selected for processing (3) * src/lib/verifier/DAVerifier.sol (6 hunks) * src/lib/verifier/test/DAVerifier.t.sol (3 hunks) * src/lib/verifier/test/RollupInclusionProofs.t.sol (2 hunks)
Files skipped from review as they are similar to previous changes (3) * src/lib/verifier/DAVerifier.sol * src/lib/verifier/test/DAVerifier.t.sol * src/lib/verifier/test/RollupInclusionProofs.t.sol
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
zhiqiangxu commented 6 months ago

Thanks for reporting this 🙏

Can you provide test cases that fail without this fix?

I don't have a test case, I found this problem when code review.

The main take-away is that the extra _root parameter is unnecessary and should use the one inside AttestationProof.tuple

rach-id commented 6 months ago

@zhiqiangxu I confirm the bug, would you be able to add the tests? Also, this fix should also be done for: verifySharesToDataRootTupleRoot and verifyRowRootToDataRootTupleRoot. Would you be down to updating this PR to include fix + tests for those too?

If not, I'll gladly pick this PR up and add the necessary changes :D

zhiqiangxu commented 6 months ago

@zhiqiangxu I confirm the bug, would you be able to add the tests? Also, this fix should also be done for: verifySharesToDataRootTupleRoot and verifyRowRootToDataRootTupleRoot. Would you be down to updating this PR to include fix + tests for those too?

If not, I'll gladly pick this PR up and add the necessary changes :D

I fixed the mentioned functions, please take a look, and feel free to add more tests if necessary:)