search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
341 stars 281 forks source link

Decide and integrate the blob module with authz #1546

Open evan-forbes opened 1 year ago

evan-forbes commented 1 year ago

We are adding authz to the application in #1540, but we are pushing the integration with the blob module to a different PR. This is mainly because there are different ways to do this, each of which unblocking potential features.

We should decide on and then implement that integration. The decision might involve an ADR.

liamsi commented 1 year ago

Also, everything beyond the generic authorization should be accompanied with a test. re:

cmwaters commented 1 year ago

@evan-forbes Is this something we want to punt till after mainnet?

evan-forbes commented 1 year ago

its less important than other things imo since we have feegrant, but if we can we should try to squeeze it in per the onsite decision.

evan-forbes commented 1 year ago

to update this after a sync discussions. Since authz requires wrapping the PFB, this complicates the block encoding, specifically for zk rollups or custom parsers of the PFB namespace.

we are also able to get the same functionality using a custom feegrant interface per investigation by @cmwaters, so I'm going to remove this off of mainnet but won't close the issue.