search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
330 stars 271 forks source link

Drop minio/sha256-simd in favor of crypto/sha256 for Go 1.21+ #1826

Open liamsi opened 1 year ago

liamsi commented 1 year ago

see: https://github.com/multiformats/go-multihash/pull/173

please also open issues in other repos (core, maybe nmt etc)

rootulp commented 1 year ago 
$ go mod why github.com/minio/sha256-simd
# github.com/minio/sha256-simd
github.com/celestiaorg/celestia-app/pkg/appconsts
github.com/celestiaorg/rsmt2d
github.com/minio/sha256-simd

so I created https://github.com/celestiaorg/rsmt2d/issues/161

rootulp commented 1 year ago

please also open issues in other repos (core, maybe nmt etc)

Just checked and

  1. celestia-core doesn't depend on minio/sha256-simd. See https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/go.mod
  2. nmt doesn't depend on minio/sha256-simd. See https://github.com/celestiaorg/nmt/blob/master/go.mod