celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
348 stars 299 forks source link

misspelled words #2848

Closed rootulp closed 1 year ago

rootulp commented 1 year ago

Context

https://goreportcard.com/report/github.com/celestiaorg/celestia-app

Problem

Screenshot 2023-11-16 at 10 18 01 AM

Proposal

  1. Fix the misspelled words
  2. Ensure that CI will fail if new misspelled words are added. We already have this enabled so it may require investigation https://github.com/celestiaorg/celestia-app/blob/fc03393dce943532c618da53069f9331fc575b1d/.golangci.yml#L9
Caerlower commented 1 year ago

Context

https://goreportcard.com/report/github.com/celestiaorg/celestia-app

Problem

Screenshot 2023-11-16 at 10 18 01 AM

Proposal

  1. Fix the misspelled words
  2. Ensure that CI will fail if new misspelled words are added. We already have this enabled so it may require investigation https://github.com/celestiaorg/celestia-app/blob/fc03393dce943532c618da53069f9331fc575b1d/.golangci.yml#L9

I would like to do this issue can you assign this issue to me.

rootulp commented 1 year ago

Nvm it looks like the previous report was based on a view of the codebase that was a year old. I refreshed the report via Refresh now and now there are no more reported spelling mistakes

Screenshot 2023-11-17 at 10 03 57 AM
Caerlower commented 1 year ago

Nvm it looks like the previous report was based on a view of the codebase that was a year old. I refreshed the report via Refresh now and now there are no more reported spelling mistakes

Screenshot 2023-11-17 at 10 03 57 AM

okay, thanks for assigning me the request.