celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
347 stars 296 forks source link

TestPriorityByGasPrice flake #2942

Open rootulp opened 11 months ago

rootulp commented 11 months ago

Description

We're currently experiencing a flake see:

--- FAIL: TestPriorityTestSuite (7.08s)
    --- FAIL: TestPriorityTestSuite/TestPriorityByGasPrice (1.02s)
        priority_test.go:118: 
                Error Trace:    /home/runner/work/celestia-app/celestia-app/app/test/priority_test.go:118
                Error:          Should be true
                Test:           TestPriorityTestSuite/TestPriorityByGasPrice
    network.go:48: tearing down testnode
FAIL

Acceptance Criteria

rootulp commented 9 months ago

Slightly different flake for the same test:

--- FAIL: TestPriorityTestSuite (6.08s)
    --- FAIL: TestPriorityTestSuite/TestPriorityByGasPrice (0.00s)
        priority_test.go:89: 
                Error Trace:    /home/runner/work/celestia-app/celestia-app/app/test/priority_test.go:89
                Error:          Not equal: 
                                expected: 0x0
                                actual  : 0xd
                Test:           TestPriorityTestSuite/TestPriorityByGasPrice
    network.go:48: tearing down testnode

Ref: https://github.com/celestiaorg/celestia-app/actions/runs/7789508543/job/21241291035?pr=3079

evan-forbes commented 4 weeks ago
--- FAIL: TestPriorityTestSuite (12.07s)
    --- FAIL: TestPriorityTestSuite/TestPriorityByGasPrice (1.01s)
        priority_test.go:124: 
                Error Trace:    /home/runner/work/celestia-app/celestia-app/app/test/priority_test.go:124
                Error:          Should be true
                Test:           TestPriorityTestSuite/TestPriorityByGasPrice
    network.go:46: tearing down testnode

continuing to hit this flake